Messages in this thread | | | Date | Fri, 20 Apr 2007 09:42:29 +0100 (IST) | From | Mel Gorman <> | Subject | Re: [PATCH -mm] fix undefined symbol if CONFIG_PAGE_GROUP_BY_MOBILITY not set |
| |
On Fri, 20 Apr 2007, Pierre Peiffer wrote:
> Hi, > > This is a fix against the patch > do-not-group-pages-by-mobility-type-on-low-memory-systems.patch (include in -mm > tree): > The error "page_group_by_mobility_disabled undefinied" occured if > CONFIG_PAGE_GROUP_BY_MOBILITY is not set. > > Signed-off-by: Pierre Peiffer <pierre.peiffer@bull.net> >
Hi,
Your fix looks correct but the compile-time option CONFIG_PAGE_GROUP_BY_MOBILITY was removed in a patch I sent to Andrew two days ago. It went into mm-commits last night so this problem should no longer exist.
> --- > mm/page_alloc.c | 5 +++++ > 1 file changed, 5 insertions(+) > > Index: b/mm/page_alloc.c > =================================================================== > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -2297,6 +2297,7 @@ void __meminit build_all_zonelists(void) > } > vm_total_pages = nr_free_pagecache_pages(); > > +#ifdef CONFIG_PAGE_GROUP_BY_MOBILITY > /* > * Disable grouping by mobility if the number of pages in the > * system is too low to allow the mechanism to work. It would be > @@ -2313,6 +2314,10 @@ void __meminit build_all_zonelists(void) > num_online_nodes(), > page_group_by_mobility_disabled ? "off" : "on", > vm_total_pages); > +#else > + printk("Built %i zonelists. Total pages: %ld\n", > + num_online_nodes(), vm_total_pages); > +#endif > } > > /* > > > -- > Pierre >
-- Mel Gorman Part-time Phd Student Linux Technology Center University of Limerick IBM Dublin Software Lab - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |