Messages in this thread | | | Date | Fri, 20 Apr 2007 16:29:31 +0100 | From | Alan Cox <> | Subject | Re: [PATCH 1/3] Char: mxser_new, fix recursive locking |
| |
> Signed-off-by: Jan "Yenya" Kasprzak <kas@fi.muni.cz> > Cc: Jiri Slaby <jirislaby@gmail.com> > Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Acked-by: Alan Cox <alan@redhat.com> > > --- linux-2.6.21-rc2/drivers/char/mxser_new.c.orig 2007-04-20 15:41:46.000000000 +0200 > +++ linux-2.6.21-rc2/drivers/char/mxser_new.c 2007-04-20 15:46:46.000000000 +0200 > @@ -2230,7 +2230,14 @@ > port->mon_data.rxcnt += cnt; > port->mon_data.up_rxcnt += cnt; > > + /* > + * We are called from an interrupt context with &port->slock > + * being held. Drop it temporarily in order to prevent > + * recursive locking. > + */ > + spin_unlock(&port->slock); > tty_flip_buffer_push(tty); > + spin_lock(&port->slock); > } > - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |