| Date | Sun, 1 Apr 2007 22:37:01 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH 3/16] vt-underline-color.diff |
| |
On Sun, 1 Apr 2007 20:14:14 +0200 (MEST) Jan Engelhardt <jengelh@linux01.gwdg.de> wrote:
> static u8 vgacon_build_attr(struct vc_data *c, u8 color, u8 intensity, > - u8 blink, u8 underline, u8 reverse); > + u8 blink, u8 underline, u8 reverse, u8);
ug. It's better to include the names of the parameters, IMO. But mixing the two styles like this is nuts.
Happily, the declaration is unneeded anyway, so I'll just delete it. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|