lkml.org 
[lkml]   [2007]   [Apr]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] ipv4/ipvs: Convert to kthread API
    On Thu, 19 Apr 2007 18:04:36 +0900
    Simon Horman <horms@verge.net.au> wrote:

    > On Thu, Apr 19, 2007 at 01:58:57AM -0600, Eric W. Biederman wrote:
    > > From: Eric W. Biederman <ebiederm@xmission.com>
    > >
    > > Modify startup of ipvs sync threads to use kthread_run
    > > instead of a weird combination of calling kernel_thread
    > > to start a fork_sync_thread whose hole purpose in life was
    > > to call kernel_thread again starting the actually sync thread
    > > which called daemonize.
    > >
    > > To use kthread_run I had to move the name calcuation from
    > > sync_thread into start_sync_thread resulting in a small
    > > amount of code motion.
    > >
    > > The result is simpler and more maintainable piece of code.
    >
    > Thanks Eric, I'll review this and get back to you shortly.
    >

    There still seems to be quite a lot of complexity in this driver's
    thread handling which could be removed if we did a full conversion
    to the kthread API.

    It all looks.... surprisingly complex in there.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-04-20 01:03    [W:0.025 / U:61.712 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site