lkml.org 
[lkml]   [2007]   [Apr]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] macintosh/therm_pm72.c: Convert to kthread API.
    Date
    From: Eric W. Biederman <ebiederm@xmission.com>

    This patch modifies startup of the kfand to use kthread_run
    not a combination of kernel_thread and daemonize, making
    the code a little simpler and more maintaintable.

    Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
    Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
    ---
    drivers/macintosh/therm_pm72.c | 11 ++++++-----
    1 files changed, 6 insertions(+), 5 deletions(-)

    diff --git a/drivers/macintosh/therm_pm72.c b/drivers/macintosh/therm_pm72.c
    index b002a4b..7e9cbb7 100644
    --- a/drivers/macintosh/therm_pm72.c
    +++ b/drivers/macintosh/therm_pm72.c
    @@ -121,6 +121,7 @@
    #include <linux/reboot.h>
    #include <linux/kmod.h>
    #include <linux/i2c.h>
    +#include <linux/kthread.h>
    #include <asm/prom.h>
    #include <asm/machdep.h>
    #include <asm/io.h>
    @@ -161,7 +162,7 @@ static struct slots_pid_state slots_state;
    static int state;
    static int cpu_count;
    static int cpu_pid_type;
    -static pid_t ctrl_task;
    +static int ctrl_task;
    static struct completion ctrl_complete;
    static int critical_state;
    static int rackmac;
    @@ -1779,8 +1780,6 @@ static int call_critical_overtemp(void)
    */
    static int main_control_loop(void *x)
    {
    - daemonize("kfand");
    -
    DBG("main_control_loop started\n");

    down(&driver_lock);
    @@ -1859,7 +1858,6 @@ static int main_control_loop(void *x)
    machine_power_off();
    }

    - // FIXME: Deal with signals
    elapsed = jiffies - start;
    if (elapsed < HZ)
    schedule_timeout_interruptible(HZ - elapsed);
    @@ -1954,9 +1952,12 @@ static int create_control_loops(void)
    */
    static void start_control_loops(void)
    {
    + struct task_struct *task;
    init_completion(&ctrl_complete);

    - ctrl_task = kernel_thread(main_control_loop, NULL, SIGCHLD | CLONE_KERNEL);
    + task = kthread_run(main_control_loop, NULL, "kfand");
    + if (!IS_ERR(task))
    + ctrl_task = 1;
    }

    /*
    --
    1.5.0.g53756
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-04-19 10:15    [W:0.023 / U:0.696 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site