Messages in this thread | | | Date | Tue, 17 Apr 2007 18:09:55 -0500 | From | Matt Mackall <> | Subject | Re: slab allocators: Remove obsolete SLAB_MUST_HWCACHE_ALIGN |
| |
On Mon, Apr 16, 2007 at 10:35:21PM -0700, Christoph Lameter wrote: > The flag SLAB_MUST_HWCACHE_ALIGN is > > 1. Never checked by SLAB at all. > > 2. A duplicate of SLAB_HWCACHE_ALIGN for SLUB > > 3. Fulfills the role of SLAB_HWCACHE_ALIGN for SLOB. > > The only remaining use is in sparc64 and ppc64 and their use there > reflects some earlier role that the slab flag once may have had. If > its specified then SLAB_HWCACHE_ALIGN is also specified. > > The flag is confusing, inconsistent and has no purpose. > > Remove it.
Hmm, at one point this was needed by SLOB to boot on x86, I wonder when that changed? But if SLAB is using the other define now, I'm happy to switch.
> Signed-off-by: Christoph Lameter <clameter@sgi.com>
Signed-off-by: Matt Mackall <mpm@selenic.com> -- Mathematics is the supreme nostalgia of our time. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |