lkml.org 
[lkml]   [2007]   [Apr]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] ALPHA: support graphics on non-zero PCI domains (take 2)
    On Sun, Apr 15, 2007 at 11:01:15AM +0200, Sam Ravnborg wrote:
    > > + if (pci_vga_hose && __is_mem_vga(addr)) {
    > > h = pci_vga_hose->index;
    >
    > This code snippet is used in two places.
    > A better approach would be to define a small inline function
    > that is empty in the NON HOSe case to avod the ifdefs in the
    > code logic.

    Ok. Actually we have a macro for this.

    > > +#ifndef CONFIG_ALPHA_GENERIC
    > > +EXPORT_SYMBOL(tsunami_ioportmap);
    > > +EXPORT_SYMBOL(tsunami_ioremap);
    > > +#endif
    >
    > It looks strange that the function is always defined but conditionally exported.
    > Also usual style is to place EXPORT right after closing brace of function -
    > (with no empty lines in-between).

    In a generic kernel the IO functions are never addressed directly,
    only via machine vector, so there is no point in exporting them.
    What about something like EXPORT_SYMBOL_NONGENERIC() macro?

    I agree with your other comments.

    Ivan.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-04-15 13:25    [W:0.021 / U:216.280 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site