Messages in this thread | | | Subject | Re: [PATCH 7/17] jffs2: convert jffs2_gc_fetch_page to read_cache_page | From | David Woodhouse <> | Date | Sun, 15 Apr 2007 11:52:47 +0100 |
| |
On Wed, 2007-04-11 at 19:49 -0700, Nate Diller wrote: > Replace jffs2_gc_fetch_page() and jffs2_gc_release_page() using the > read_cache_page() and put_kmapped_page() calls, and update the call site > accordingly. Explicit calls to kmap()/kunmap() make the code more clear. > > Signed-off-by: Nate Diller <nate.diller@gmail.com>
Please don't remove the jffs2_gc_{fetch,release}_page functions. The reason they're in a separate file is because that file (fs.c) is built on Linux only, while the file you're moving the code into (gc.c) is OS-agnostic; it's used on other sytems (eCos) too.
Rather than forcing eCos and any other systems which have a JFFS2 port to implement a crappy Linux 'emulation' layer, I try to keep the Linuxisms localised to certain files which can be completely reimplemented for a non-Linux port.
-- dwmw2
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |