lkml.org 
[lkml]   [2007]   [Apr]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ACPI: more verbose thermal zone shutdown message
Hi!

> while debug some strange termal shutdowns I wrote this patch to get more
> information in /var/log/messages about the reason for the shutdown. I
> think this would be useful in general.
>
> Danny
>
> From: Danny Kukawka <dkukawka@suse.de>
> Subject: ACPI: more verbose thermal zone shutdown message
>
> add more information to acpi thermal zone shutdown message for easier
> debugging
>
> Signed-off-by: Danny Kukawka <dkukawka@suse.de>

Yes, please.

(I actually had similar patch in my tree forever).

> if (tz->temperature >= tz->trips.critical.temperature) {
> - printk(KERN_WARNING PREFIX "Critical trip point\n");
> + printk(KERN_WARNING PREFIX
> + "Critical trip point (%ld C) reached on thermal zone [%s]\n",
> + KELVIN_TO_CELSIUS(tz->trips.critical.temperature),
> + acpi_device_bid(tz->device));
> tz->trips.critical.flags.enabled = 1;
> } else if (tz->trips.critical.flags.enabled)
> tz->trips.critical.flags.enabled = 0;
>
> printk(KERN_EMERG
> - "Critical temperature reached (%ld C), shutting down.\n",
> - KELVIN_TO_CELSIUS(tz->temperature));
> + "Critical temperature reached (%ld C on [%s] with trip point set to: %ld C), shutting down.\n",
> + KELVIN_TO_CELSIUS(tz->temperature),
> + acpi_device_bid(tz->device),
> + KELVIN_TO_CELSIUS(tz->trips.critical.temperature));
> +

Why two printks with same info, and why is one of them WARNING and
second EMERG?

Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-04-15 22:03    [W:0.048 / U:0.320 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site