Messages in this thread | | | From | Herbert Xu <> | Subject | Re: kernel BUG at net/core/skbuff.c in linux-2.6.21-rc6 | Date | Sat, 14 Apr 2007 16:00:12 +1000 |
| |
David Miller <davem@davemloft.net> wrote: > >> It seems we fail to reserve enough headroom for the case >> buf[0] == PPP_ALLSTATIONS and buf[1] != PPP_UI. >> >> Can you try this patch please? > > Any confirmation of this fix yet?
FWIW the fix definitely looks correct (the bug has been there for years at least) and it does match the crash dump. In fact, there is only a single skb_push (the only thing that can generate an under panic) in ppp_async.c and this is the one that Patrick has fixed.
Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |