Messages in this thread | | | Date | Sun, 15 Apr 2007 04:43:54 +0400 | From | Anton Vorontsov <> | Subject | Re: [PATCH 3/7] [RFC] Battery monitoring class |
| |
On Fri, Apr 13, 2007 at 05:49:39PM +0400, Anton Vorontsov wrote: > I'll convert mXh to uXh a bit later, if there will no further objections > against uXh. Also I'd like to hear if there any objections on > mA/mV -> uA/uV conversion. I think we'd better keep all units at the > same order/precision.
Okay, would it make sense to use "long" instead of "int" after "milli" to "micro" conversion? On 32 bit machines int gives +-2147483648 limit. So 2147 volts/amperes/...
Though 2147 amperes is unrealistic for batteries, but if used in calculations it could be dangerous.
For example: di->life_sec = -((di->accum_current_uAh - di->empty_uAh) * 3600) / di->current_uA;
It can be also solved (and I voting for it) by typecasting to long in the driver itself.
Would it also make sense to use int64_t instead of long? And how should it passed to printk in portable way? I guess printk (vsprintf) does not support PRIx notation as defined in /usr/include/inttypes.h ?
-- Anton Vorontsov email: cbou@mail.ru backup email: ya-cbou@yandex.ru irc://irc.freenode.org/bd2 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |