Messages in this thread | | | Subject | RE: [PATCH 1/1] cciss: kconfig patch to make cciss dependent onscsi for SG_IO ioctl | Date | Fri, 13 Apr 2007 13:58:41 +0100 | From | "Cameron, Steve" <> |
| |
Well, with SCSI turned off, it didn't compile:
drivers/block/cciss.c: In function `cciss_ioctl': drivers/block/cciss.c:1180: error: `SCSI_IOCTL_GET_IDLUN' undeclared (first use in this function) drivers/block/cciss.c:1180: error: (Each undeclared identifier is reported only once drivers/block/cciss.c:1180: error: for each function it appears in.) drivers/block/cciss.c:1181: error: `SCSI_IOCTL_GET_BUS_NUMBER' undeclared (first use in this function) make[2]: *** [drivers/block/cciss.o] Error 1 make[1]: *** [drivers/block] Error 2 make: *** [drivers] Error 2
-- steve
-----Original Message----- From: James Bottomley [mailto:James.Bottomley@SteelEye.com] Sent: Thu 4/12/2007 5:07 PM To: Mike Miller (OS Dev) Cc: akpm@linux-foundation.org; jens.axboe@oracle.com; linux-kernel@vger.kernel.org; linux-scsi@vger.kernel.org; Cameron, Steve Subject: Re: [PATCH 1/1] cciss: kconfig patch to make cciss dependent onscsi for SG_IO ioctl On Thu, 2007-04-12 at 16:27 -0500, Mike Miller (OS Dev) wrote: > This kconfig patch makes cciss dependent on scsi for the new SG_IO ioctl we just > added. If cciss is built into the kernel it makes sures that scsi is also statically > linked. If scsi is a module then cciss will also be built as a module. Please consider > this for inclusion.
Erm, I don't think this is necessary: SG_IO is a property of the block layer, not SCSI (as in it will work without SCSI even present). SCSI has a special driver: the sg driver that has its own implementation of SG_IO, but that's the only connection.
James
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |