Messages in this thread | | | From | (Eric W. Biederman) | Subject | Re: [PATCH 2/3] make kthread_create() more scalable | Date | Fri, 13 Apr 2007 17:34:46 -0600 |
| |
Oleg Nesterov <oleg@tv-sign.ru> writes:
> If kernel_thread(kthread) succeeds, kthread() can not fail on its path to > complete(&create->started) + schedule(). After that it can't be woken because > nobody can see the new task yet. This means: > > - we don't need tasklist_lock for find_task_by_pid().
Well we do need rcu_read_lock(); But if we are going to wait until the thread has run we can just pass back current.
> - create_kthread() doesn't need to wait for create->started. Instead, > kthread_create() first waits for create->created to get the result of > kernel_thread(), then waits for create->started to synchronize with > kthread().
We can do even better. We only need a single completion. If it was an error create_create can complete it. Otherwise kthread() can complete it.
Patch in a bit as soon as I finish testing...
Eric - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |