Messages in this thread | | | From | David Howells <> | Subject | Re: [PATCH 3/17] afs: convert afs_dir_get_page to read_kmap_page | Date | Thu, 12 Apr 2007 19:57:23 +0100 |
| |
Nate Diller <nate.diller@gmail.com> wrote:
> Hmmm you're right. Is your security work going into the next -mm?
I don't know. Andrew hasn't said anything. Andrew? Are you waiting for it to go through DaveM's networking tree?
> If so, I'll just re-base this cleanup patch on that ... at the very least I > want to get rid of afs_dir_put_page().
That's reasonable.
> Also, did you consider passing the key pointer directly and modifying the > readpage actor to simply cast the pointer back, like > read_mapping_page(mapping, page, (struct file *)key)? It seems like a waste > to allocate a whole file struct on the stack just for the ->private field.
There's one small problem with that... And that's filemap_nopage() (it passes vma->vm_file to readpage() unconditionally). Unless, of course, your patches fix that too...
David - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |