Messages in this thread | | | Date | Wed, 11 Apr 2007 11:36:40 -0700 | From | "H. Peter Anvin" <> | Subject | Re: [PATCH] console UTF-8 fixes |
| |
Egmont Koblinger wrote: > +static int is_zero_width(long ucs) > +{ > + static const struct interval zero_width[] = { /* lots */ > + };
I'm still unhappy about these large search tables in the kernel, not because they take a huge amount of space (it's not that much), but because they're invariably going to be stale, as they're Unicode-version dependent.
At least please put them in a separate .c file and include a script to generate them clean from UnicodeData.txt.
Besides, would it not make more sense to have a single table with the width information, if you insist on having one, instead of multiple ones?
-hpa - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |