lkml.org 
[lkml]   [2007]   [Apr]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 7/7] ALPHA: support graphics on non-zero PCI domains
On Wed, Apr 11, 2007 at 12:30:48PM +0400, Ivan Kokshaysky wrote:
> +VGA_MAP_MEM(unsigned long xaddr, unsigned int size)
> +{
> + /* Create a new VGA ioport resource WRT the hose it is on. */
> + if (pci_vga_hose && pci_vga_hose->index) {
> + static struct resource alpha_vga =
> + { .name = "alpha-vga+", .start = 0x3C0, .end = 0x3DF };
> + struct resource new_vga = alpha_vga;
> +
> + new_vga.start += pci_vga_hose->io_space->start;
> + new_vga.end += pci_vga_hose->io_space->start;
> + request_resource(&ioport_resource, &new_vga);

This leaks the local stack frame variable new_vga into the
resource tree, does it not? Shouldn't you be kmallocing this?


r~
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-04-11 18:09    [W:0.111 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site