[lkml]   [2007]   [Apr]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 1/13] fs: convert core functions to zero_user_page
    On Tue, 10 April 2007 22:56:38 -0700, Andrew Morton wrote:
    > And I'm surprised that this:
    > +static inline void memclear_highpage_flush(struct page *page, unsigned int offset, unsigned int size)
    > +{
    > + return zero_user_page(page, offset, size);
    > +}
    > compiled. zero_user_page() returns void...

    As does memclear_highpage_flush(). Some of my code looks like:
    void some_func(...)
    if (foo)
    return do_foo(...);
    if (bar)
    return do_bar(...);

    do_foo() and do_bar() also return void. Saves an extra line for the
    return statment and the brackets.

    Doesn't help in the code you quoted, of course.


    Measure. Don't tune for speed until you've measured, and even then
    don't unless one part of the code overwhelms the rest.
    -- Rob Pike
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2007-04-11 17:01    [W:0.025 / U:0.076 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site