Messages in this thread | | | Date | Wed, 11 Apr 2007 19:01:39 +0530 | From | Gautham R Shenoy <> | Subject | Re: [PATCH] kthread: Don't depend on work queues |
| |
On Wed, Apr 11, 2007 at 03:48:05PM +0400, Oleg Nesterov wrote: > On 04/11, Gautham R Shenoy wrote: > > > > On Wed, Apr 11, 2007 at 12:13:34PM +0200, Rafael J. Wysocki wrote: > > > > > > It should be calling try_to_freeze() somewhere anyway. We may need to freeze > > > all tasks in some cases. > > > > How about > > for (;;) { > > try_to_freeze(); > > > > ? > > Why?
If some event (defintely NOT cpu hotplug) needs this thread frozen.
> > > This change allows us to make all the worker threads freezeable by default. > > >From cpu-hotplug perspective, helper_wq was the only singlethreaded > > non-freezeable workqueue. > > I think Eric's patch is what you need. We should _not_ freeze kthreadd(), we > need kthread_create() after freezing. Now it doesn't depend on workqueues, we > can freeze them all, single-thread or not. >
These were my exact thoughts.
> I like this patch.
Same here.
> > Oleg. >
Thanks and Regards gautham.
-- Gautham R Shenoy Linux Technology Center IBM India. "Freedom comes with a price tag of responsibility, which is still a bargain, because Freedom is priceless!" - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |