lkml.org 
[lkml]   [2007]   [Apr]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/7] Containers (V8): Add generic multi-subsystem API to containers
On Fri, Apr 06, 2007 at 04:32:24PM -0700, menage@google.com wrote:
> +struct container_subsys {
> + int (*create)(struct container_subsys *ss,
> + struct container *cont);
> + void (*destroy)(struct container_subsys *ss, struct container *cont);
> + int (*can_attach)(struct container_subsys *ss,
> + struct container *cont, struct task_struct *tsk);
> + void (*attach)(struct container_subsys *ss, struct container *cont,
> + struct container *old_cont, struct task_struct *tsk);
> + void (*fork)(struct container_subsys *ss, struct task_struct *task);
> + void (*exit)(struct container_subsys *ss, struct task_struct *task);
> + int (*populate)(struct container_subsys *ss,
> + struct container *cont);
> + void (*bind)(struct container_subsys *ss, struct container *root);

Is the first argument into all the callbacks, struct container_subsys *ss,
necessary?

> +struct container_subsys cpuset_subsys = {
> + .name = "cpuset",
> + .create = cpuset_create,
> + .destroy = cpuset_destroy,
> + .can_attach = cpuset_can_attach,
> + .attach = cpuset_attach,
> + .populate = cpuset_populate,
> + .subsys_id = cpuset_subsys_id,
> + .early_init = 1,
> +};

We seem to be missing a register call here as well ..

--
Regards,
vatsa
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-04-10 16:47    [W:0.174 / U:0.200 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site