Messages in this thread | | | Date | Tue, 10 Apr 2007 08:24:22 +0200 | From | Ingo Molnar <> | Subject | Re: [patch] sched: align rq to cacheline boundary |
| |
* Siddha, Suresh B <suresh.b.siddha@intel.com> wrote:
> Align the per cpu runqueue to the cacheline boundary. This will > minimize the number of cachelines touched during remote wakeup.
> -static DEFINE_PER_CPU(struct rq, runqueues); > +static DEFINE_PER_CPU(struct rq, runqueues) ____cacheline_aligned_in_smp;
ouch!! Now how did _that_ slip through. The runqueues had been cacheline-aligned for ages. Or at least, they were supposed to be.
could you see any improvement in profiles or workloads with this patch applied? (just curious - it's an obviously right fix)
> Signed-off-by: Suresh Siddha <suresh.b.siddha@intel.com>
Acked-by: Ingo Molnar <mingo@elte.hu>
Ingo - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |