Messages in this thread | | | Date | Thu, 8 Mar 2007 20:34:05 -0500 | From | Benjamin LaHaise <> | Subject | Re: sys_write() racy for multi-threaded append? |
| |
> Actually, I think it would make the kernel (negligibly) faster to bump > f_pos before the vfs_write() call. Unless fget_light sets fput_needed > or the write doesn't complete cleanly, you won't have to touch the > file table entry again after vfs_write() returns. You can adjust
Any number of things can cause a short write to occur, and rewinding the file position after the fact is just as bad. A sane app has to either serialise the writes itself or use a thread safe API like pwrite().
-ben -- "Time is of no importance, Mr. President, only life is important." Don't Email: <zyntrop@kvack.org>. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |