lkml.org 
[lkml]   [2007]   [Mar]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Subject[PATCH 0/2] Repair pci_restore_state when used with device resets
    Date

    Well this is clearly a weird tangent from the topic of this thread but
    it looks to have found some real bugs even if they aren't the ones we
    are looking for.

    In short pci_save_state and pci_restore_state are used to two primary
    was: As a pair called from the suspend and restore routines. One save
    to multiple restores usually present in hardware reset routines.

    The additions to save/restore msi, pci-e and pci-x state failed to take
    this second usage scenario into account.

    The next two patches address this problem.

    This should directly fix the issue observed with the tg3, with multiple
    saves and a single restore.

    It happens that to handle the reset case cleanly we also need to support
    the odd usage model of the current e1000 driver.

    I have never have figured out how to get suspend/resume actually
    working on any of my machines so the code path is untested. But the
    patches are trivial and pretty much obviously correct.

    So if a couple people could do a quick suspend/resume test on these
    patches to confirm I'm not blind that would be great.

    Eric
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-03-08 21:03    [W:0.024 / U:31.140 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site