lkml.org 
[lkml]   [2007]   [Mar]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 3/3] Use correct IDE error recovery
    > On Wednesday 21 February 2007, Suleiman Souhlal wrote:
    > > IDE error recovery is using WIN_IDLEIMMEDIATE which was only valid for
    > > IDE V1 and IDE V2. Modern drives will not be able to recover using
    > > this error handling. The correct thing to do is issue a SRST followed
    > > by a SET_FEATURES.
    >
    > This change looks fine, indeed we are better of using SRST + SET_FEATURES
    > than IDLE_IMMEDIATE.
    >
    > > Signed-off-by: Suleiman Souhlal <suleiman@google.com>

    Acked-by: Alan Cox <alan@redhat.com>

    And this is well worth doing - IDLEIMMEDIATE blows the mind of some later
    drive firmware that doesn't expect to be treated in an IDE v1 manner.


    Alan
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-03-08 01:03    [W:3.954 / U:1.096 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site