Messages in this thread | | | Date | Thu, 8 Mar 2007 01:05:33 +0000 | From | Alan Cox <> | Subject | Re: [PATCH 3/3] Use correct IDE error recovery |
| |
> On Wednesday 21 February 2007, Suleiman Souhlal wrote: > > IDE error recovery is using WIN_IDLEIMMEDIATE which was only valid for > > IDE V1 and IDE V2. Modern drives will not be able to recover using > > this error handling. The correct thing to do is issue a SRST followed > > by a SET_FEATURES. > > This change looks fine, indeed we are better of using SRST + SET_FEATURES > than IDLE_IMMEDIATE. > > > Signed-off-by: Suleiman Souhlal <suleiman@google.com>
Acked-by: Alan Cox <alan@redhat.com>
And this is well worth doing - IDLEIMMEDIATE blows the mind of some later drive firmware that doesn't expect to be treated in an IDE v1 manner.
Alan - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |