Messages in this thread | | | Date | Wed, 7 Mar 2007 14:41:01 -0800 | From | Andrew Morton <> | Subject | Re: [PATCH] remove_arg_zero() rewrite |
| |
On Wed, 07 Mar 2007 23:09:57 +0100 Peter Zijlstra <a.p.zijlstra@chello.nl> wrote:
> On Wed, 2007-02-21 at 15:41 -0800, Andrew Morton wrote: > > > I mean.... what the hell? > > > > As you appear to have managed to work out what the sorry thing is trying to > > do, would you have time to simply rip it out and completely rewrite it, > > including a nice comment telling the world what this function's function is? > > > > Because what we have there is beyond repairing. > > Something like so? > Boots uml seemingly without errors. > > --- > Rewrite remove_arg_zero() to be more parseable by untwisted minds. >
Sorry, Nick already had a go at this:
ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.21-rc2/2.6.21-rc2-mm2/broken-out/exec-fix-remove_arg_zero.patch
But your patch has a nice comment and has to be better ;)
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |