Messages in this thread | | | From | (Eric W. Biederman) | Subject | Re: [PATCH 2/3] msi: Fixup the msi enable/disable logic | Date | Tue, 06 Mar 2007 22:19:06 -0700 |
| |
Michael Ellerman <michael@ellerman.id.au> writes:
> > Hi Eric, comments below .. > > > I get the reasoning for disabling MSI before we start writing back the > config space, but don't we want to re-enable MSI on the way out?
We are restoring the entire msi flags register which includes the enable bit, setting it a second time is gratuitous.
In addition if we are restoring the register when the enable bit is not set. (because we don't have a mask bit) enabling the msi state is actually the wrong thing to do. But I admit that case can only happen after the additions in my last patch.
Eric
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |