lkml.org 
[lkml]   [2007]   [Mar]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: Linux v2.6.21-rc3


    On Wed, 7 Mar 2007, Benjamin Herrenschmidt wrote:
    >
    > On Tue, 2007-03-06 at 20:59 -0800, Linus Torvalds wrote:
    >
    > > Linus Torvalds (2):
    > > Revert "[PATCH] LOG2: Alter get_order() so that it can make use of ilog2() on a constant"
    > > Linux 2.6.21-rc3
    >
    > Greg, I think we should revert that patch in 2.6.20.x stable serie too
    > as get_order is broken there as well, causing random kernel memory
    > corruption every now and then among others.

    Did you confirm that that was indeed the cause of the problem you saw?

    As far as I can tell, the bug (because it tested the wrong #define) would
    only affect the constant-size case, and only for something larger than a
    single page, and only for a non-power-of-two size. So it looked fairly
    hard to trigger, if only because all the obvious constants I saw seemed
    to already be powers-of-two..

    So did you hunt it down to a particular cases where it triggers?

    Linus
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-03-07 16:41    [W:0.027 / U:88.564 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site