Messages in this thread | | | Date | Wed, 7 Mar 2007 14:59:14 +0300 | From | Evgeniy Polyakov <> | Subject | Re: connector: Bugfix for cn_call_callback() |
| |
On Wed, Mar 07, 2007 at 12:26:12PM +0100, Philipp Reisner (philipp.reisner@linbit.com) wrote: > Hi Evgeniy,
Hi Philipp.
> When one stresses the connector code, with sending many messages > from userspace to kernel, one could get in the "unlikely()" > part in cn_call_callback(). > > There a new __cbq gets allocated, and a NULL pointer got assigned > to the callback by dereferencing __cbq. This is the bug. The right > thing is the dereference the original __cbq. Therefore the bugfix > is to use a new variable for the newly allocated __cbq. > > This is tested, and it fixes the issue.
Yes, your patch is correct.
> Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com> > Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>
I will push it, thanks a lot.
-- Evgeniy Polyakov - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |