Messages in this thread | | | Date | Tue, 6 Mar 2007 09:22:12 +0100 | From | Pavel Machek <> | Subject | Re: [PATCH 1/3] libata: add missing PM callbacks |
| |
Hi!
> > Much complexity for little gain. Who is running _without_ CONFIG_PM > > these days? > > Embedded people, I guess. The problem here is that if we are gonna > support !CONFIG_PM configuration and try to reduce the kernel/module > images size for such case, we end up sprinkling #ifdef's all over huge > number of device drivers.
Ok, in separate mail I see you already did the work...
> If we determine to drop !CONFIG_PM configuration, I'm happy with that > too but we need to determine something here. Alternatives... > > 1. drop !CONFIG_PM configuration > 2. continue to sprinkle #ifdef's over device drivers > 3. find out prettier way to mark PM functions
...of 3., and code is nicely generic and fairly simple. I thought it would be too much work to implemente it, and it would get too messy.
Given that it is so simple, I believe 3. is the best option. We can still do 1. in future if we feel like so... Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |