Messages in this thread | | | Subject | Re: [PATCH 1/2] ibmebus: dynamic addiiton/removal of adapters, uevent, root device based on struct device | From | John Rose <> | Date | Tue, 06 Mar 2007 15:51:42 -0600 |
| |
> This adds two sysfs attributes to /sys/bus/ibmebus which can > be used to notify the ebus driver of added / removed ebus > devices in the OF device tree.
We are seeing several build errors when attempting to apply this to 2.6.21-rc2:
CC arch/powerpc/kernel/ibmebus.o arch/powerpc/kernel/ibmebus.c: In function "ibmebus_register_device_common": arch/powerpc/kernel/ibmebus.c:192: warning: ignoring return value of "device_create_file", declared with attribute warn_unused_result arch/powerpc/kernel/ibmebus.c: At top level: arch/powerpc/kernel/ibmebus.c:373: error: "of_device_uevent" undeclared here (not in a function) arch/powerpc/kernel/ibmebus.c: In function "ibmebus_store_probe": arch/powerpc/kernel/ibmebus.c:399: error: assignment of read-only location arch/powerpc/kernel/ibmebus.c:401: error: assignment of read-only location arch/powerpc/kernel/ibmebus.c: In function "ibmebus_store_remove": arch/powerpc/kernel/ibmebus.c:434: error: assignment of read-only location arch/powerpc/kernel/ibmebus.c:436: error: assignment of read-only location arch/powerpc/kernel/ibmebus.c: In function "ibmebus_bus_init": arch/powerpc/kernel/ibmebus.c:474: warning: ignoring return value of "bus_create_file", declared with attribute warn_unused_result arch/powerpc/kernel/ibmebus.c:475: warning: ignoring return value of "bus_create_file", declared with attribute warn_unused_result make[1]: *** [arch/powerpc/kernel/ibmebus.o] Error 1 make: *** [arch/powerpc/kernel] Error 2 make: *** Waiting for unfinished jobs.... Here is a sample error from the patch referenced above: +static ssize_t ibmebus_store_probe(struct bus_type *bus, + const char *buf, size_t count) +{ + struct device_node *dn = NULL; + struct ibmebus_dev *dev; + char *loc_code; + + buf[count] = '\0';
The "buf" variable is declared const, and then immediately written to.
Thanks- John
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |