Messages in this thread | | | Date | Mon, 05 Mar 2007 22:52:41 +0100 | From | Eric Dumazet <> | Subject | Re: [patch] epoll use a single inode ... |
| |
Davide Libenzi a écrit : > * using the inode number. > */ > error = -ENOMEM; > - sprintf(name, "[%lu]", inode->i_ino); > + sprintf(name, "[%p]", ep); > this.name = name; > this.len = strlen(name);
Small remark : you can avoid strlen(), since sprintf gives you the value :)
this.len = sprintf(name, "[%p]", ep);
Also, your patch description is not complete : you forgot to say that epoll dentries are not anymore hashed into global dcache hashtable :)
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |