lkml.org 
[lkml]   [2007]   [Mar]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2] Add suspend/resume for HPET


    On Sat, 31 Mar 2007, Maxim Levitsky wrote:
    >
    > So maybe I was right afrer all,
    > Maybe it is better to add a suspend/resume hook to each clock source and call
    > it from timekeeping_resume() ?

    Umm.. WHy not make the device tree look like this:

    -- "clocksource" -- +-- HPET
    |
    +-- TSC
    |
    +-- i8259
    |
    +-- lapic timer
    |
    .. whatever else

    and use the "struct device" that we *have* for this? The whole "struct
    device" is literally designed to do this, and to be embedded into whatever
    bigger structures you have that describes higher-level behaviour. Ie you'd
    put a "struct device" inside the "struct clocksource".

    That thingalready *has* the suspend/resume hooks, and it will mean that
    people will see the clocks in the device tree rather than have a new
    notion.


    Linus
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-03-31 19:17    [W:0.023 / U:61.172 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site