lkml.org 
[lkml]   [2007]   [Mar]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[patch 23/37] V4L: msp_attach must return 0 if no msp3400 was found.
    -stable review patch.  If anyone has any objections, please let us know.

    ------------------
    From: Hans Verkuil <hverkuil@xs4all.nl>

    V4L: msp_attach must return 0 if no msp3400 was found.

    Returning -1 causes the probe to stop, but it should just continue
    instead. This patch fixes an annoying 'i2c_adapter i2c-7: Client
    creation failed at 0x44 (-1)' kernel message that appeared in 2.6.20

    (cherry picked from commit 3284b4e077cb2322754ea7455b8f8af7ce3777b8)

    Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
    Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
    Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    drivers/media/video/msp3400-driver.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/drivers/media/video/msp3400-driver.c
    +++ b/drivers/media/video/msp3400-driver.c
    @@ -825,7 +825,7 @@ static int msp_attach(struct i2c_adapter
    if (msp_reset(client) == -1) {
    v4l_dbg(1, msp_debug, client, "msp3400 not found\n");
    kfree(client);
    - return -1;
    + return 0;
    }

    state = kmalloc(sizeof(*state), GFP_KERNEL);
    @@ -859,7 +859,7 @@ static int msp_attach(struct i2c_adapter
    v4l_dbg(1, msp_debug, client, "not an msp3400 (cannot read chip version)\n");
    kfree(state);
    kfree(client);
    - return -1;
    + return 0;
    }

    msp_set_audio(client);
    --
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-03-30 23:21    [W:0.020 / U:1.076 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site