Messages in this thread | | | Date | Fri, 30 Mar 2007 12:54:37 -0700 | From | Pete Zaitcev <> | Subject | Re: usb hid: reset NumLock |
| |
On Fri, 30 Mar 2007 14:14:20 -0400, "Dmitry Torokhov" <dmitry.torokhov@gmail.com> wrote:
> > I didn't like a) layering violation, and b) that they defeat filtering > > unconditionally. Why have any filtering then? > > > > Instead, I propose for USB HID driver to reset NumLock on probe. Like this: > > > > --- a/drivers/usb/input/hid-core.c
> This is fine and that's what we do in atkbd probe but maybe we should > move that in input core and reset leds as part of > input_register_device()?
Sure, as long as it works. I think (as much as I understand), that we already attempt to do this indirectly. input_register_device invokes ->start handlers, and the kbd_start attempts to reset LEDs, but fails because of the state filtering.
-- Pete - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |