Messages in this thread | | | Date | Fri, 30 Mar 2007 12:46:41 -0400 | From | "Dmitry Torokhov" <> | Subject | Re: FF layer restrictions [Was: [PATCH 1/1] Input: add sensable phantom driver] |
| |
On 3/28/07, Jiri Slaby <jirislaby@gmail.com> wrote: > Jiri Slaby napsal(a): > > Dmitry Torokhov napsal(a): > >> On Tuesday 27 March 2007 17:34, johann deneux wrote: > >>> What about adding a member to ff_effect which would be the number of the motor? > >>> We can't change the layout of ff_effect too much though, so we have to > >>> find unused bits and put them to work. > >>> > >>> For instance, we could replace > >>> > >>> __u16 type; > >>> > >>> by > >>> > >>> __u8 motor; > >>> __u8 type; > >>> > >> Splitting type field seems to be a good idea. > > > > Maybe stupid question, but what about endianness + backward compatibility? > > If we split it into motor,type sequence, it would break LE (untouched BE), > > if we do type,motor, it is OK for LE (broken BE). > > Aha, and the question is: do > > #ifdef __BIG_ENDIAN > #else > #endif > > ? >
I am so tempted to say "screw BE, there is not many users of FF layer" but I am afraid we will have to do that #ifdef-fu.
-- Dmitry - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |