lkml.org 
[lkml]   [2007]   [Mar]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] i386: add command line option "local_apic_timer_c2_ok"


    On Thu, 29 Mar 2007, Andi Kleen wrote:
    >
    > Here's a patch. I don't have a system with C1E, so i only tested that
    > the apic timer still works on a older AMD box.

    I think this looks better than what we have now, but it would look even
    better if the core CPUID stuff was in arch/i386/kernel/cpu/amd.c, and we
    simply had X86_FEATURE_BROKEN_C1_LAPIC etc..

    And then the apic.c code would just check

    if (boot_cpu_has(X86_FEATURE_BROKEN_C1_LAPIC))
    return -1;

    or similar.

    Doing the same for C2 and C3 gives us a clean way to have all these
    per-vendor things in their relevant places, rather than having various
    vendor-specific checks sprinkled in random places..

    That's *especially* true for something like this that can hit both on
    x86-64 and i386, where the cpuid logic is shared, but the APIC logic is
    *not* shared. If I read your patch correctly, this only fixes it on 32-bit
    platforms, and I don't think the problem is in any way 32-bit specific, is
    it?

    Linus
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-03-29 23:25    [W:0.021 / U:4.884 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site