lkml.org 
[lkml]   [2007]   [Mar]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] revoke: break cow for private mappings
On 3/28/07, Nick Piggin <nickpiggin@yahoo.com.au> wrote:
> > + ret = get_user_pages(tsk, tsk->mm, vma->vm_start,
> > + vma->vm_end-vma->vm_start, 1, 1, NULL,
> > + NULL);
>
> get_user_pages length argument is in # of pages, rather than address range,
> I think. vma_pages is what you want?

Yes.

On 3/28/07, Nick Piggin <nickpiggin@yahoo.com.au> wrote:
> > + up_write(&mm->mmap_sem);
>
> I think you just need down_read of mmap_sem here?

Indeed. Thanks Nick.

Pekka
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-03-28 12:13    [W:0.033 / U:2.908 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site