lkml.org 
[lkml]   [2007]   [Mar]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] Add support for deferrable timers (respun)
    On Wed, Mar 28, 2007 at 01:06:35PM +0200, Andi Kleen wrote:
    > Venki Pallipadi <venkatesh.pallipadi@intel.com> writes:
    > > +++ new/kernel/timer.c 2007-03-26 15:19:35.000000000 -0800
    > > @@ -74,7 +74,7 @@
    > > tvec_t tv3;
    > > tvec_t tv4;
    > > tvec_t tv5;
    > > -} ____cacheline_aligned_in_smp;
    > > +} ____cacheline_aligned;
    >
    > Why this change? It should be aligned to 2 bytes anyways.

    Just wanted to be cautious of all archs and all compilers.

    > > static DEFINE_PER_CPU(tvec_base_t *, tvec_bases) = &boot_tvec_bases;
    > >
    > > +/*
    > > + * The lowest bit of base ptr in timer is used as a flag to indicate
    > > + * 'deferrable' nature of the timer. Functions below help us manage that flag.
    > > + */
    > > +static inline unsigned int tbase_get_deferrable(struct tvec_t_base_s *base)
    > > +{
    > > + return ((unsigned int)base & TBASE_DEFERRABLE_FLAG);
    >
    > This will warn on 64bit for cast ptr -> int

    OK. Will change this to ptr->long->int in the update patch.

    Thanks,
    Venki
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-03-28 18:45    [W:0.023 / U:22.860 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site