Messages in this thread | | | Subject | Re: [PATCH -mm] Blackfin arch: add kdebug header file | From | "Wu, Bryan" <> | Date | Tue, 27 Mar 2007 11:40:37 +0800 |
| |
On Mon, 2007-03-26 at 23:45 +0200, Arnd Bergmann wrote: > I can see nothing wrong with your patches, but you should make the > patch descriptions a little clearer: >
Thanks Arnd. I posted almost ten patches yesterday. Converting ten patches to preformatted Emails is terrible manually, you know.
How does a kernel guru to do this, send out dozens of patch emails a day? Is there any convenient tools to help this?
> On Monday 26 March 2007, Wu, Bryan wrote: > > Hi folks, > > No need for this line, if it's there, Andrew just needs to remove > it from the changelog. > > > This patch adds kdebug.h header file to blackfin architecture. > > This line is completely redundant, as it states the same information > as the subject. You should give some background information here, > like: > > kdebug.h is needed for kprobes. > > For trivial patches where the subject already tells the whole story > (e.g. 'remove redundant declaration of foo'), just leave out the > description entirely except for the Signed-off-by. > > Arnd <>< > you can even leave out the description
I really appreciate your warmly advice.
Best Regards, Bryan - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |