lkml.org 
[lkml]   [2007]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH -mm] Blackfin arch: add kdebug header file
From
Date
On Mon, 2007-03-26 at 23:45 +0200, Arnd Bergmann wrote:
> I can see nothing wrong with your patches, but you should make the
> patch descriptions a little clearer:
>

Thanks Arnd. I posted almost ten patches yesterday. Converting ten
patches to preformatted Emails is terrible manually, you know.

How does a kernel guru to do this, send out dozens of patch emails a
day? Is there any convenient tools to help this?

> On Monday 26 March 2007, Wu, Bryan wrote:
> > Hi folks,
>
> No need for this line, if it's there, Andrew just needs to remove
> it from the changelog.
>
> > This patch adds kdebug.h header file to blackfin architecture.
>
> This line is completely redundant, as it states the same information
> as the subject. You should give some background information here,
> like:
>
> kdebug.h is needed for kprobes.
>
> For trivial patches where the subject already tells the whole story
> (e.g. 'remove redundant declaration of foo'), just leave out the
> description entirely except for the Signed-off-by.
>
> Arnd <><
> you can even leave out the description

I really appreciate your warmly advice.

Best Regards,
Bryan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-03-27 05:43    [W:0.058 / U:1.660 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site