lkml.org 
[lkml]   [2007]   [Mar]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH -mm] Fix lseek on /proc/kcore
From
Date
On Thu, 2007-03-22 at 12:56 +0300, Alexey Dobriyan wrote:
> Signed-off-by: Alexey Dobriyan <adobriyan@sw.ru>
> ---
>
> fs/proc/inode.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> --- a/fs/proc/inode.c
> +++ b/fs/proc/inode.c
> @@ -167,8 +167,9 @@ static loff_t proc_reg_llseek(struct fil
> llseek = pde->proc_fops->llseek;
> spin_unlock(&pde->pde_unload_lock);
>
> - if (llseek)
> - rv = llseek(file, offset, whence);
> + if (!llseek)
> + llseek = default_llseek;
> + rv = llseek(file, offset, whence);
>

this has potential impact way outside kcore......
did you audit all proc users to see if they can deal with lseek?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-03-22 14:19    [from the cache]
©2003-2011 Jasper Spaans