lkml.org 
[lkml]   [2007]   [Mar]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [linux-pm] 2.6.21-rc4-mm1: freezing of processes broken
    On Wed, 21 Mar 2007 15:45:16 +0100 "Rafael J. Wysocki" <rjw@sisk.pl> wrote:

    > On Wednesday, 21 March 2007 15:23, Oleg Nesterov wrote:
    > > On 03/21, Nigel Cunningham wrote:
    > > >
    > > > On Tue, 2007-03-20 at 19:23 -0600, Eric W. Biederman wrote:
    > > > > >> > Rafael J. Wysocki napsal(a):
    > > > > >
    > > > > > Bisection shows that the freezing of processes has been broken by one of the
    > > > > > patches:
    > > > > >
    > > > > > remove-the-likelypid-check-in-copy_process.patch
    > > > >
    > > > > Grr. Oleg's review of remove-the-likelypid-check-in-copy-process
    > > > > showed it to be questionable (and it was just an optimization)
    > > > > so we can get rid of that one easily.
    > > > >
    > > > > Although all it did that was really questionable was add
    > > > > the idle process to the global process list and bump a process
    > > > > count when we forked the idle process. Not dramatically dangerous
    > > > > things.
    > > >
    > > > Could the freezer code be trying to freeze the idle thread as a result?
    > >
    > > Yes. remove-the-likelypid-check-in-copy_process.patch make idle threads
    > > visible to for_each_process/do_each_thread. Note also that idle threads
    > > have ->mm != NULL. freezer, oom_kill, move_task_off_dead_cpu, etc, should
    > > not see idle threads, but they do now.
    >
    > Well, I think this is a good enough reason for asking Andrew to drop this
    > patch.

    Or we change the freezer to skip pid==0 tasks.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-03-21 17:25    [W:0.023 / U:0.412 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site