lkml.org 
[lkml]   [2007]   [Mar]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 1/7] Introduce the pagetable_operations and associated helper macros.
    From
    Date
    On Wed, 2007-03-21 at 09:50 -0500, Adam Litke wrote:
    > On Tue, 2007-03-20 at 16:24 -0700, Dave Hansen wrote:
    > > On Mon, 2007-03-19 at 13:05 -0700, Adam Litke wrote:
    > > >
    > > > +#define has_pt_op(vma, op) \
    > > > + ((vma)->pagetable_ops && (vma)->pagetable_ops->op)
    > > > +#define pt_op(vma, call) \
    > > > + ((vma)->pagetable_ops->call)
    > >
    > > Can you get rid of these macros? I think they make it a wee bit harder
    > > to read. My brain doesn't properly parse the foo(arg)(bar) syntax.
    > >
    > > + if (has_pt_op(vma, copy_vma))
    > > + return pt_op(vma, copy_vma)(dst_mm, src_mm, vma);
    > >
    > > + if (vma->pagetable_ops && vma->pagetable_ops->copy_vma)
    > > + return vma->pagetable_ops->copy_vma(dst_mm, src_mm, vma);
    > >
    > > I guess it does lead to some longish lines. Does it start looking
    > > really nasty?
    >
    > Yeah, it starts to look pretty bad. Some of these calls are in code
    > that is already indented several times.

    can we just make sure these things are never NULL in the first place?
    would obsolete a lot of the checks, which are also runtime overhead as
    well!
    --
    if you want to mail me at work (you don't), use arjan (at) linux.intel.com
    Test the interaction between Linux and your BIOS via http://www.linuxfirmwarekit.org

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-03-21 16:09    [W:0.020 / U:31.436 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site