lkml.org 
[lkml]   [2007]   [Mar]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [linux-pm] 2.6.21-rc4-mm1: freezing of processes broken
    Date
    On Wednesday, 21 March 2007 02:23, Eric W. Biederman wrote:
    > "Rafael J. Wysocki" <rjw@sisk.pl> writes:
    >
    > > On Tuesday, 20 March 2007 22:06, Rafael J. Wysocki wrote:
    > >> On Tuesday, 20 March 2007 21:58, Jiri Slaby wrote:
    > >> > Rafael J. Wysocki napsal(a):
    > >> > > Actually, the problem is 100% reproducible on my system too and I doubt
    > > it's
    > >> > > caused by the recent freezer patches.
    > >> >
    > >> > I don't know what exactly do you mean by recent, but 2.6.21-rc3-mm2 works
    > >> > for me.
    > >>
    > >> Thanks for the confirmation.
    > >>
    > >> The patches I was talking about had already been in 2.6.21-rc3-mm2, so the
    > >> reason of this failure must be different.
    > >
    > > Bisection shows that the freezing of processes has been broken by one of the
    > > patches:
    > >
    > > remove-the-likelypid-check-in-copy_process.patch
    >
    > Grr. Oleg's review of remove-the-likelypid-check-in-copy-process
    > showed it to be questionable (and it was just an optimization)
    > so we can get rid of that one easily.
    >
    > Although all it did that was really questionable was add
    > the idle process to the global process list and bump a process
    > count when we forked the idle process. Not dramatically dangerous
    > things.

    I think this patch is the culprit, though, as it seems that the freezer tries
    to freeze the idle process and fails. Yesterday I didn't have the time to
    figure out the exact reason, I'll try to look at it later today.

    > > use-task_pgrp-task_session-in-copy_process.patch
    >
    > As I recall that patch was pretty trivial, and shouldn't have
    > anything to do with the freezer. The process freezer doesn't care
    > about pids does it?

    No, it doesn't, at least not directly. I'll try to run the kernel with this
    change and without remove-the-likelypid-check-in-copy_process.patch .

    Greetings,
    Rafael
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-03-21 13:09    [W:0.022 / U:182.904 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site