lkml.org 
[lkml]   [2007]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: 2.6.21-rc4-mm1
On Mon, 19 Mar 2007 20:56:23 -0800 Andrew Morton wrote:

>
> Temporarily at
>
> http://userweb.kernel.org/~akpm/2.6.21-rc4-mm1/
>
> Will appear later at
>
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.21-rc4/2.6.21-rc4-mm1/


I think that this:

config EEPROM_93CX6
tristate "EEPROM 93CX6 support"
---help---
This is a driver for the EEPROM chipsets 93c46 and 93c66.
The driver supports both read as well as write commands.
should not be in lib/Kconfig. lib/ is not for drivers.
or (simpler) s/driver/library/
but I think I'd rather see it in drivers/misc/.


and the help text needs to be indented 2 more spaces...

---
~Randy
boilerplate:
*** Remember to use Documentation/SubmitChecklist when testing your code ***
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
\
 
 \ /
  Last update: 2007-03-21 00:53    [from the cache]
©2003-2011 Jasper Spaans