lkml.org 
[lkml]   [2007]   [Mar]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [linux-pm] [PATCH 2/2 -stable] libata: add missing CONFIG_PM in LLDs
Hello, Nigel.

Nigel Cunningham wrote:
>> Index: work1/drivers/ata/ahci.c
>> ===================================================================
>> --- work1.orig/drivers/ata/ahci.c
>> +++ work1/drivers/ata/ahci.c
>> @@ -225,10 +225,12 @@ static void ahci_thaw(struct ata_port *a
>> static void ahci_error_handler(struct ata_port *ap);
>> static void ahci_vt8251_error_handler(struct ata_port *ap);
>> static void ahci_post_internal_cmd(struct ata_queued_cmd *qc);
>> +#ifdef CONFIG_PM
>> static int ahci_port_suspend(struct ata_port *ap, pm_message_t mesg);
>> static int ahci_port_resume(struct ata_port *ap);
>> static int ahci_pci_device_suspend(struct pci_dev *pdev, pm_message_t mesg);
>> static int ahci_pci_device_resume(struct pci_dev *pdev);
>
> Wouldn't it be simpler to add
>
> #else
> #define ahci_port_suspend(port, message) (NULL)
>
> etc (or something similar)?

ahci_port_suspend() is used to fill ata_port_ops vector, so it needs to
be a function. If you're talking about defining NULL function, yeah,
that will remove half of CONFIG_PMs but would require dummy definitions
for all functions. I think both are ugly. :-)

I'm working on a linker trick. Please take a look at the following thread.

http://thread.gmane.org/gmane.linux.ide/16475

--
tejun
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-03-03 04:23    [from the cache]
©2003-2011 Jasper Spaans