Messages in this thread Patch in this message | | | Date | Mon, 19 Mar 2007 10:26:32 +0100 | From | Adrian Bunk <> | Subject | [2.6 patch] drivers/usb/input/gtco.c: fix a use-before-check |
| |
NULL checks should be before the first dereference.
Spotted by the Coverity checker.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- --- linux-2.6.21-rc3-mm2/drivers/usb/input/gtco.c.old 2007-03-19 09:29:44.000000000 +0100 +++ linux-2.6.21-rc3-mm2/drivers/usb/input/gtco.c 2007-03-19 09:30:31.000000000 +0100 @@ -1047,13 +1047,10 @@ static void gtco_disconnect(struct usb_i /* Grab private device ptr */ struct gtco *device = usb_get_intfdata (interface); - struct input_dev *inputdev; - - inputdev = device->inputdevice; /* Now reverse all the registration stuff */ if (device) { - input_unregister_device(inputdev); + input_unregister_device(device->inputdevice); usb_kill_urb(device->urbinfo); usb_free_urb(device->urbinfo); usb_buffer_free(device->usbdev, REPORT_MAX_SIZE, - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |