lkml.org 
[lkml]   [2007]   [Mar]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 01 of 33] IB/ipath - add ability to set and clear IB local loopback
From
Date
This patch format is somewhat inconvenient:

> # HG changeset patch
> # User Bryan O'Sullivan <bos@pathscale.com>

I assume this is the real author of the patch (as opposed to the
sender of the email)? git would prefer to see

From: Bryan O'Sullivan <bos@pathscale.com>

in the body of the email.

> # Date 1173994464 25200
> # Node ID b1d05f3486f8bba1dd3c5cbca39f06a5e1b3d6fb
> # Parent 0d37971d4ab0c8b6f7a8f6e8222112321982498f

And all of these "#" lines get put into the patch description.

> IB/ipath - add ability to set and clear IB local loopback

No need to duplicate the subject line.

And incidentally, it would be better to use "IB/ipath: " instead of
"IB/ipath -" as a prefix, to match the canonical style of
"<subsystem>: " for patch headers.

Don't worry about resending, I can fix this up, but it would be nice
not to have to worry about it.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-03-19 22:25    [W:0.217 / U:3.720 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site