Messages in this thread | | | From | Andi Kleen <> | Subject | Re: [PATCH][5/5][resend] floppy.c: Fix device_create_file() warning | Date | Mon, 19 Mar 2007 16:13:04 +0100 |
| |
> > - device_create_file(&floppy_device[drive].dev,&dev_attr_cmos); > + err = device_create_file(&floppy_device[drive].dev, &dev_attr_cmos); > + if (err) > + printk(KERN_WARNING "Unable to create sysfs attribute " > + "file for floppy device: %s\n", > + floppy_device[drive].name);
That change looks pretty useless. Either the error should be handled correctly by bailing out or the warn_unused_results should be dropped.
-Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |