Messages in this thread | | | Subject | Re: [PATCH] Sanitize filesystem NLS handling | From | OGAWA Hirofumi <> | Date | Mon, 19 Mar 2007 12:46:56 +0900 |
| |
"Alexander E. Patrakov" <patrakov@ums.usu.ru> writes:
>> You allow to set any nls to codepage? If so, it is not good. > > I did this because it involved less changes. Only FAT treats codepage as a > number. All other filesystems already allow arbitrary NLS as a codepage > mount parameter.
I'm saying here, it is not good for vfat.
>> No, utf-8 makes completely wrong entry. It's more wrong than other nls. > > For any non-UTF-8 based locales, the other NLS is correct and utf8 indeed > would produce completely wrong characters. But for UTF-8 based locales, utf8 > is the only correct iocharset.
No, iocharset=utf8 is wrong always.
>>> * Makes CONFIG_NLS_DEFAULT and CONFIG_CODEPAGE_DEFAULT adjustable at >>> runtime via the following mechanisms: >> >> The configurable sounds sane, and it may help some case. But, it should >> not be system global. At least, I think the default would be per-filesystem, >> otherwise some configs seems to be needed for other filesystem after all. > > OK, now I see that your primary objection is to merging options, and > disagree (incorrect locale setup on your side is suspected). For meaningful > discussion, I want to see the following: > > 1) Output of "locale -a" > 2) Output of "yes --help" from the same terminal > 3) The correct iocharset and codepage for mounting FAT filesystems on USB > flash drives that are known readable under Windows (here "correct" = "ls in > this terminal shows filenames correctly"). > 4) The same for SMB filesystems.
Ah, ok. I'm thinking one locale is not enough, at least for now. Why I can't use utf8 for jfs or something, and use other nls for vfat? -- OGAWA Hirofumi <hirofumi@mail.parknet.co.jp> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |