lkml.org 
[lkml]   [2007]   [Mar]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH RESEND 2/2] Fix some kallsyms_lookup() vs rmmod races
    From
    Date
    On Fri, 2007-03-16 at 14:44 +0300, Alexey Dobriyan wrote:
    > [cc'ing folks whose proc files are affected]
    >
    > kallsyms_lookup() can call module_address_lookup() which iterates over
    > modules list without module_mutex taken. Comment at the top of
    > module_address_lookup() says it's for oops resolution so races are
    > irrelevant, but in some cases it's reachable from regular code:

    Yes, this changed somewhere along the way.

    I prefer keeping the lock internal as much as possible, and have the
    crash code use an __ variant of the function.

    Note also that it might be an idea to have less-powerful accessors than
    kallsyms_lookup...

    Thanks!
    Rusty.


    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-03-18 01:49    [W:3.110 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site