Messages in this thread | | | Date | Fri, 16 Mar 2007 09:44:25 -0700 | From | Jeremy Fitzhardinge <> | Subject | Re: [patch 20/26] Xen-paravirt_ops: Core Xen implementation |
| |
Chris Wright wrote: > * Ingo Molnar (mingo@elte.hu) wrote: > >> * Jeremy Fitzhardinge <jeremy@goop.org> wrote: >> >> >>> Core Xen Implementation >>> >>> This patch is a rollup of all the core pieces of the Xen >>> implementation, including booting, memory management, interrupts, time >>> and so on. >>> >>> --- a/arch/i386/kernel/head.S >>> +++ b/arch/i386/kernel/head.S >>> @@ -535,6 +535,10 @@ unhandled_paravirt: >>> ud2 >>> #endif >>> >>> +#ifdef CONFIG_XEN >>> +#include "../xen/xen-head.S" >>> +#endif >>> >> i'd suggest to remove the #ifdef and push it into xen-head.S. >> > > That's been fixed, the two are built as seperate objects now. >
Actually, we tried it but it causes bad kernel images with some binutils, so it has to be included for now.
>>> @@ -437,9 +437,9 @@ static unsigned long native_store_tr(voi >>> >>> static void native_load_tls(struct thread_struct *t, unsigned int cpu) >>> { >>> -#define C(i) get_cpu_gdt_table(cpu)[GDT_ENTRY_TLS_MIN + i] = t->tls_array[i] >>> - C(0); C(1); C(2); >>> -#undef C >>> + get_cpu_gdt_table(cpu)[GDT_ENTRY_TLS_MIN + 0] = t->tls_array[0]; >>> + get_cpu_gdt_table(cpu)[GDT_ENTRY_TLS_MIN + 1] = t->tls_array[1]; >>> + get_cpu_gdt_table(cpu)[GDT_ENTRY_TLS_MIN + 2] = t->tls_array[2]; >>> } >>> >> this is a cleanup unrelated to the purpose of the patch. >> > > Sure, will split out. >
Already done in Rusty's cleanup patch.
J - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |